Submit Your Ideas

We want to hear from you - vote for the features and improvements you'd most like to see, or submit your own ideas if you don't find them already listed.

Show overall "All checks have passed" status in github even on builds with incomplete "type: approval" job

I added a manual approval "trigger_rollback" job recently to my Circle 2.0 workflow and did not like the UI integration with github. On builds where I did not trigger this optional "trigger_rollback" job, the overall Github status was "Some checks haven't completed yet." (See screenshot.)

 

I talked to CircleCI support and they told me to deselect the status check for a "type: approval" job as described in this github article: https://circleci.com/docs/2.0/workflows-waiting-status/, which I had already done.

 

I still need the "trigger_rollback" job and corresponding status check. The "trigger_rollback" status check is type:approval, so I want it to be pending but I don't want the overall PR status to be pending -- instead I want the overall PR status to be green and say "All checks have passed."

  • Avatar32.5fb70cce7410889e661286fd7f1897de Guest
  • Jun 4 2018
  • Future consideration
  • Attach files
  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    17 Oct 19:43

    I'd love to have this feature. We want the approval as part of our work-in-process pipeline, without making every status check on the Pull Requests page in git show everything as pending.

  • Avatar40.8f183f721a2c86cd98fddbbe6dc46ec9
    Guest commented
    27 Nov 12:55

    Same issue here. We have an optinal approval step in case we want to manually deploy a branch to an environment. That doesn't mean that the tests are not passing. It's pretty annoying.